Enable failure store to APM datastreams#125672
Enable failure store to APM datastreams#125672rubvs wants to merge 14 commits intoelastic:mainfrom rubvs:mis-enable-failure-store
Conversation
jbaiera
left a comment
There was a problem hiding this comment.
LGTM, though this will likely need to wait until after the feature is out from behind the feature flag to be merged.
jbaiera
left a comment
There was a problem hiding this comment.
This won't handle APM data streams that already exist when applied, is that something that needs to be considered as well for this rollout?
|
@jbaiera is there a different way to also apply it to existing data streams? |
@simitt This is what the We'll need to use both the template and the cluster setting as part of the rollout. The template to enable the failure store on all data streams going forward, and the cluster setting to pick up any existing data streams from before the template update. |
carsonip
left a comment
There was a problem hiding this comment.
does changing a setting require a plugin version bump in
?|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @rubvs, I've created a changelog YAML for you. |
@jbaiera should the @rubvs @1pkg please clarify with PMs (@akhileshpok @mlunadia @LucaWintergerst ) that enabling FS for all apm data streams by default is ok (in the past we have focused on MIS/serverless, but afaics this PR would enable it also for APM Server, so we need to coordinate). |
|
Left a comment in the original issue: https://github.com/elastic/apm-managed-service/issues/1541#issuecomment-3028247155 |
|
Superseded by #131296 |
Closes https://github.com/elastic/apm-managed-service/issues/1541
Enable failure store to APM datastreams